Only display the input fields that are configured in the scope #631

AdamGrzybkowski · 2025-05-16T08:20:07Z

Description

This PR allows displaying only certain AboutInputFields in the editors per the scope config.

The public API was already done. The changes made are:

Introduce the option to pick specific fields within the Demo App.
Pass the aboutFields from the scope config to the AboutEditorViewModel and set the visibility in the state.
Adjust the UI component to respect the visibility flags.

aboutFields.mp4

Testing Steps

Launch the demo app
Select the About or AvatarAndAbout scope
Tap on the About fields
Select the ones you want
Close the sheet
Open the QE
Verify the selected fields are visible

Copilot

Pull Request Overview

This PR implements a configuration option that restricts the display of About input fields in the editors by passing a set of visible fields down through the view model and UI components. Key changes include:

Replacing usages of AboutInputField with AboutEditorField in the editor components and tests.
Updating the view model and profile mapping to respect the configured visibility flags.
Adding a new about fields picker in the demo app to allow dynamic field configuration.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
AboutEditorViewModelTest.kt	Updated tests to use the new visibility configuration and field type.
AboutEditorTest.kt	Modified tests to verify the UI state correctly reflects visible fields.
QuickEditorScopeOption.kt	Added a getter to expose aboutFields based on the scope configuration.
ProfessionalSection.kt, PersonalSection.kt, AboutSection.kt	Wrapped field rendering with conditional visibility checks and updated field types.
AboutFields.kt	Modified data classes and update functions to use AboutEditorField with a new visible flag.
AboutEditorViewModel.kt	Changed the view model to map the profile using configured visible fields and updated API types.
AboutEditorEvent.kt, AboutEditor.kt	Adjusted event and editor definitions to use AboutEditorField.
AboutFieldsBottomSheet.kt	Adapted the bottom sheet component to work with the field configuration.
AvatarUpdateTab.kt	Integrated an about fields picker and updated scope configuration to use the chosen fields.
demo-app/build.gradle.kts	Added a dependency on composable core components.

...ar-quickeditor/src/main/java/com/gravatar/quickeditor/ui/abouteditor/AboutEditorViewModel.kt

wpmobilebot · 2025-05-16T08:25:05Z

📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.

	App Name	Gravatar Demo
	Commit	`4179c74`
	Direct Download	`gravatar-demo-prototype-build-pr631-4179c74.apk`

AdamGrzybkowski · 2025-05-16T10:31:49Z

@etoledom I've marked this as a Draft. I'm not 100% happy with how the state is modeled in the AboutEditorViewModel and I want to change that.

AdamGrzybkowski · 2025-05-16T11:51:17Z

@etoledom This is now ready to review. I did modify the model for the AboutEditor state in 94bcfd7. Mainly, I've decided to keep about fields as a Set rather than having them all defined with a visibility flag set. Now we simply hold only those that should be visible. This significantly reduced the complexity of the UI components and even reduced the number of them as they are now more generic.

Copilot

Pull Request Overview

This PR adds support for displaying only configured About input fields in the editor based on scope settings.

Passes aboutFields from scope config into AboutEditorViewModel to control visibility.
Refactors state and UI to use AboutEditorField sets instead of fixed AboutFields classes.
Introduces a bottom sheet in the demo app for selecting visible About input fields.

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
AboutEditorViewModelTest.kt	Updated tests to use new `AboutEditorField` API
AboutEditorViewModel.kt	Accepts `visibleAboutFields` and maps profile fields accordingly
AboutSection.kt	Refactored UI to render dynamic field sets
AboutInputField.kt	Added ordering and category helpers for fields
AboutFieldsBottomSheet.kt	New UI for picking visible About fields in demo app
AvatarUpdateTab.kt	Integrated bottom sheet and bound selected fields in demo app

Comments suppressed due to low confidence (3)

gravatar-quickeditor/src/test/java/com/gravatar/quickeditor/ui/abouteditor/AboutEditorViewModelTest.kt:258

You’ve added a test for personal-only visibility—consider adding a complementary test for the professional-only case to ensure that section toggling works as expected.

fun `given only personal about section visible when profile fetched then uiState is updated`() = runTest {

demo-app/src/main/java/com/gravatar/demoapp/ui/components/AboutFieldsBottomSheet.kt:44

[nitpick] The parameter name aboutFields in this sheet conflicts with the editor’s aboutFields type (AboutEditorField). Consider renaming to selectedFields or similar for clarity.

internal fun AboutFieldsBottomSheet( aboutFields: Set<AboutInputField>,

gravatar-quickeditor/src/test/java/com/gravatar/quickeditor/ui/abouteditor/AboutEditorViewModelTest.kt:8

Tests reference AboutEditorField, but there's no import; add import com.gravatar.quickeditor.ui.abouteditor.AboutEditorField to avoid compilation errors.

import com.gravatar.quickeditor.ui.editor.AboutInputField

...quickeditor/src/main/java/com/gravatar/quickeditor/ui/abouteditor/components/AboutSection.kt

...ar-quickeditor/src/main/java/com/gravatar/quickeditor/ui/abouteditor/AboutEditorViewModel.kt

gravatar-quickeditor/src/main/java/com/gravatar/quickeditor/ui/editor/AboutInputField.kt

There's a crash caused by rememberSaveable { mutableStateOf(AboutInputField.all) } The default saver doesn't support non-primitive types.

etoledom

Looking great 🎉

One small detail comparing with Figma:
It seems that when there's only one section present, the section title is not being shown:

Figma	Implemented

This is how it was implemented on iOS also.

If there are fields from only one section, there's no section title. But when there are at least 1 field from each section, the section titles are being shown.

Same section	Different sections

AdamGrzybkowski · 2025-05-19T07:41:48Z

Ohh I missed that detail, thanks.

AdamGrzybkowski · 2025-05-19T08:04:50Z

@etoledom Fixed!

etoledom

Looking great! Thank you for the update 🙏

AdamGrzybkowski added this to the Quick Editor - About Info milestone May 16, 2025

AdamGrzybkowski requested review from etoledom and Copilot May 16, 2025 08:20

AdamGrzybkowski added the [Feature] Gravatar-Quickeditor Gravatar Quick Editor module label May 16, 2025

Copilot AI reviewed May 16, 2025

View reviewed changes

...ar-quickeditor/src/main/java/com/gravatar/quickeditor/ui/abouteditor/AboutEditorViewModel.kt Outdated Show resolved Hide resolved

AdamGrzybkowski marked this pull request as draft May 16, 2025 08:28

AdamGrzybkowski marked this pull request as ready for review May 16, 2025 08:29

AdamGrzybkowski marked this pull request as draft May 16, 2025 10:31

AdamGrzybkowski marked this pull request as ready for review May 16, 2025 11:49

AdamGrzybkowski force-pushed the adam/GRA-33 branch from 52b2e27 to a80dc53 Compare May 16, 2025 12:36

AdamGrzybkowski requested a review from Copilot May 16, 2025 12:37

Copilot AI reviewed May 16, 2025

View reviewed changes

AdamGrzybkowski force-pushed the adam/GRA-81_2 branch from b4cad07 to eba852e Compare May 16, 2025 13:09

Base automatically changed from adam/GRA-81_2 to feature/quick_editor_about_info May 16, 2025 13:44

AdamGrzybkowski added 5 commits May 16, 2025 16:04

Add option to select about fields in the demo app

f49415f

Use the aboutFields from the scope config in AboutEditor

cf22d3d

Generate new screenshots

6e11e09

Remodel state management for the AboutInputField

23a7182

Generate quickeditor.api file

e412241

AdamGrzybkowski force-pushed the adam/GRA-33 branch from a80dc53 to b451906 Compare May 16, 2025 14:06

Create custom saver for Set<AboutInputField>

004a452

There's a crash caused by rememberSaveable { mutableStateOf(AboutInputField.all) } The default saver doesn't support non-primitive types.

AdamGrzybkowski force-pushed the adam/GRA-33 branch from b451906 to 004a452 Compare May 16, 2025 14:18

etoledom reviewed May 19, 2025

View reviewed changes

Only show section labels when fields from both are visible

4179c74

AdamGrzybkowski requested a review from etoledom May 19, 2025 08:04

etoledom approved these changes May 19, 2025

View reviewed changes

AdamGrzybkowski merged commit a461f4d into feature/quick_editor_about_info May 19, 2025
14 checks passed

AdamGrzybkowski deleted the adam/GRA-33 branch May 19, 2025 14:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Only display the input fields that are configured in the scope #631

Only display the input fields that are configured in the scope #631

Uh oh!

AdamGrzybkowski commented May 16, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

wpmobilebot commented May 16, 2025 •

edited

Loading

Uh oh!

AdamGrzybkowski commented May 16, 2025

Uh oh!

AdamGrzybkowski commented May 16, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

etoledom left a comment

Uh oh!

AdamGrzybkowski commented May 19, 2025

Uh oh!

AdamGrzybkowski commented May 19, 2025

Uh oh!

etoledom left a comment

Uh oh!

Uh oh!

Uh oh!

Only display the input fields that are configured in the scope #631

Only display the input fields that are configured in the scope #631

Uh oh!

Conversation

AdamGrzybkowski commented May 16, 2025

Description

Testing Steps

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

wpmobilebot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AdamGrzybkowski commented May 16, 2025

Uh oh!

AdamGrzybkowski commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

etoledom left a comment

Choose a reason for hiding this comment

Uh oh!

AdamGrzybkowski commented May 19, 2025

Uh oh!

AdamGrzybkowski commented May 19, 2025

Uh oh!

etoledom left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

wpmobilebot commented May 16, 2025 •

edited

Loading

AdamGrzybkowski commented May 16, 2025 •

edited

Loading